Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/redis] Add missing imagePullPolicy for init-sysctl #13018

Merged
merged 1 commit into from
Apr 15, 2019
Merged

[stable/redis] Add missing imagePullPolicy for init-sysctl #13018

merged 1 commit into from
Apr 15, 2019

Conversation

eduardobaitello
Copy link
Contributor

The sysctlImage.pullPolicy value is documented, but is to used in the templates.
Signed-off-by: Eduardo Baitello [email protected]

What this PR does / why we need it:

Fix imagePullPolicy for "init-sysctl" init-containers

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @eduardobaitello. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2019
@eduardobaitello
Add missing imagePullPolicy for init-sysctl
0b6a99c 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
@eduardobaitello
Copy link
Contributor Author

/assign @prydonius

juan131
juan131 approved these changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@juan131
Copy link
Collaborator

juan131 commented Apr 15, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eduardobaitello, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 788f52c into helm:master Apr 15, 2019
TsuyoshiUshio pushed a commit to TsuyoshiUshio/charts that referenced this pull request Apr 18, 2019
@eduardobaitello @TsuyoshiUshio
Add missing imagePullPolicy for init-sysctl (helm#13018)
434584a 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
hajnej pushed a commit to hajnej/charts that referenced this pull request Apr 24, 2019
@eduardobaitello @hajnej
Add missing imagePullPolicy for init-sysctl (helm#13018)
af106d8 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@eduardobaitello @devnulled
Add missing imagePullPolicy for init-sysctl (helm#13018)
1b45a46 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
dermorz pushed a commit to dermorz/charts that referenced this pull request Apr 26, 2019
@eduardobaitello
Add missing imagePullPolicy for init-sysctl (helm#13018)
a6950e6 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
dpkirchner pushed a commit to dpkirchner/charts that referenced this pull request May 9, 2019
@eduardobaitello @dpkirchner
Add missing imagePullPolicy for init-sysctl (helm#13018)
2ff601d 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@eduardobaitello @goshlanguage
Add missing imagePullPolicy for init-sysctl (helm#13018)
269ee63 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@eduardobaitello @eyenx
Add missing imagePullPolicy for init-sysctl (helm#13018)
d820683 
The sysctlImage.pullPolicy value is documented, but is to used
in the templates
Signed-off-by: eduardobaitello <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juan131 juan131 juan131 approved these changes

@carrodher carrodher Awaiting requested review from carrodher

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@prydonius prydonius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eduardobaitello @k8s-ci-robot @juan131 @prydonius @helm-bot