This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/rabbitmq] Support configuration for the rabbitmq metrics exporter #12908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rter - generic configuration via environment variables: `metrics.env` see https://github.com/kbudde/rabbitmq_exporter#configuration - better default `capabilities` (faster metrics collection with recent rabbitmq servers): `metrics.capabilities` see https://github.com/kbudde/rabbitmq_exporter#extended-rabbitmq-capabilities Signed-off-by: Thomas Riccardi <[email protected]>
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/S
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @thomas-riccardi. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
ok-to-test
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thomas-riccardi, tompizmor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@thomas-riccardi Thanks for the PR! |
devnulled
pushed a commit
to devnulled/charts
that referenced
this pull request
Apr 25, 2019
…rter (helm#12908) - generic configuration via environment variables: `metrics.env` see https://github.com/kbudde/rabbitmq_exporter#configuration - better default `capabilities` (faster metrics collection with recent rabbitmq servers): `metrics.capabilities` see https://github.com/kbudde/rabbitmq_exporter#extended-rabbitmq-capabilities Signed-off-by: Thomas Riccardi <[email protected]>
dermorz
pushed a commit
to dermorz/charts
that referenced
this pull request
Apr 26, 2019
…rter (helm#12908) - generic configuration via environment variables: `metrics.env` see https://github.com/kbudde/rabbitmq_exporter#configuration - better default `capabilities` (faster metrics collection with recent rabbitmq servers): `metrics.capabilities` see https://github.com/kbudde/rabbitmq_exporter#extended-rabbitmq-capabilities Signed-off-by: Thomas Riccardi <[email protected]>
goshlanguage
pushed a commit
to goshlanguage/charts
that referenced
this pull request
May 17, 2019
…rter (helm#12908) - generic configuration via environment variables: `metrics.env` see https://github.com/kbudde/rabbitmq_exporter#configuration - better default `capabilities` (faster metrics collection with recent rabbitmq servers): `metrics.capabilities` see https://github.com/kbudde/rabbitmq_exporter#extended-rabbitmq-capabilities Signed-off-by: Thomas Riccardi <[email protected]>
eyenx
pushed a commit
to eyenx/charts
that referenced
this pull request
May 28, 2019
…rter (helm#12908) - generic configuration via environment variables: `metrics.env` see https://github.com/kbudde/rabbitmq_exporter#configuration - better default `capabilities` (faster metrics collection with recent rabbitmq servers): `metrics.capabilities` see https://github.com/kbudde/rabbitmq_exporter#extended-rabbitmq-capabilities Signed-off-by: Thomas Riccardi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
metrics.envsee https://github.com/kbudde/rabbitmq_exporter#configuration
capabilities(faster metrics collection with recentrabbitmq servers):
metrics.capabilitiessee https://github.com/kbudde/rabbitmq_exporter#extended-rabbitmq-capabilities
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist