This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Add note to Spinnaker doc about destination path for additionalConfigMaps #11437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 13, 2019 14:19
Signed-off-by: Miles Matthias <[email protected]>
Signed-off-by: Miles Matthias <[email protected]>
…l to beginners Signed-off-by: Miles Matthias <[email protected]>
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/XS
|
The linter is complaining because I didn't bump the chart version, but I don't think this change needs a version bump since it's just documentation. |
|
All changes require a version bump since the contents of the chart will
change.
…On Thu, Feb 14, 2019 at 1:17 PM Miles Matthias ***@***.***> wrote:
The linter is complaining because I didn't bump the chart version, but I
don't think this change needs a version bump since it's just documentation.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#11437 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZCp2qE240wrqkZlF4z7Sh-aWSMvUHWks5vNdJYgaJpZM4a8dGH>
.
|
helm-bot
added
size/XS
Signed-off-by: Miles Matthias <[email protected]>
milesmatthias
force-pushed
the
master-spin-docs
branch
from
dd1ca06 to
6dc54ed
Compare
helm-bot
added
size/XS
|
Bumped chart version. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: milesmatthias, paulczar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A suggestion for improving docs. I spent a while trying to figure out where additional configMaps are uploaded to the halyard pod on a k8s spinnaker deployment so they could be used in config scripts, and this one line would've helped.
Special notes for your reviewer:
I realize Spinnaker is deployed on multiple kinds of infra, not just k8s, which is why I didn't mention a halyard pod, but maybe there's a better way to make this note generic.
Checklist