This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/prometheus-node-exporter] Add options to change volume mount propagation #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karol Chrapek <[email protected]>
helm-bot
added
Contribution Allowed
Signed-off-by: Karol Chrapek <[email protected]>
helm-bot
added
size/S
|
/assign @gianrubio |
|
@cpanato or @gianrubio do you have any concern regaring |
|
@gianrubio any chance to merge this PR? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gianrubio, kaarolch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
3 tasks
ThoTischner
pushed a commit
to bitsbeats/charts
that referenced
this pull request
Aug 13, 2019
…ame as helm#11194 for prometheus-node-exporter) (helm#13922) Signed-off-by: Alexey Medvedchikov <[email protected]>
landorg
pushed a commit
to landorg/charts
that referenced
this pull request
Aug 19, 2019
…ame as helm#11194 for prometheus-node-exporter) (helm#13922) Signed-off-by: Alexey Medvedchikov <[email protected]> Signed-off-by: Roland Gritzer <[email protected]>
kengou
pushed a commit
to kengou/charts
that referenced
this pull request
Sep 18, 2019
…ame as helm#11194 for prometheus-node-exporter) (helm#13922) Signed-off-by: Alexey Medvedchikov <[email protected]>
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
…ame as helm#11194 for prometheus-node-exporter) (helm#13922) Signed-off-by: Alexey Medvedchikov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karol Chrapek [email protected]
What this PR does / why we need it:
This PR allow to mount volume inside node exporter with
rslaveoption - in kubernetes mountPropagation. This is useful when you would like to monitoring dynamic mounting volumes.Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]