[stable/chaoskube] Feature/structured log flag #10986

syedimam0012 · 2019-01-30T03:55:03Z

What this PR does / why we need it:

This feature adds a new flag logFormat that can be set to either "text" (i.e. default) or "json" without affecting the existing behaviour.

Special notes for your reviewer:

PR in the source has to be merged before this one, which will return a new appVersion that requires to be updated here. Chart versionalso needs to be bumped.
@linki

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

DCO signed
Chart Version bumped
Variables are documented in the README.md

linki · 2019-01-30T11:19:43Z

@syedimam0012 Thank you!

Please leave out all the changed files that are not under ./stable/chaoskube.
Bump the chart version to: 0.15.0
Bump the appVersion and imageTag to: 0.13.0 (image will be pushed once we merge your PR)

linki · 2019-01-30T11:22:08Z

stable/chaoskube/values.yaml

@@ -40,6 +40,9 @@ excludedDaysOfYear:
 # Set specific Timezone for Actions to take place
 timezone: UTC

+# If nothing set, defaults to "text". Switch to "json" to enable structured logging
+logFormat:


You could use logFormat: text here and leave out the {{- if .Values.logFormat }} stuff in deployment.yaml.

I tend to like that more in this chart but ultimately you can decide 😄

That's what I did initially before I had encountered logFormat: empty was failing. Happy to revert this and leave "text" in the helm values. ☺️

For upgrading it's actually better to do the if stuff. Thank you 😃

linki · 2019-02-05T14:10:54Z

lgtm, thank you @syedimam0012 😀

marc-sensenich · 2019-02-19T15:34:07Z

@linki would you be able to /approve this for it to be released?

marc-sensenich · 2019-03-13T12:54:21Z

stable/chaoskube/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v1
 name: chaoskube
-version: 0.14.0
-appVersion: 0.12.1
+version: 0.15.0


With #11780 this version number should change to 1.1.0

Thanks, @marc-sensenich for the update.
@linki would you want me to update this to 1.1.0 ?

maorfr · 2019-04-22T06:17:17Z

/assign
/ok-to-test

@syedimam0012, is this good to go?
if so, would you mind rebasing?

Signed-off-by: Syed Imam <[email protected]>

syedimam0012 · 2019-04-30T05:07:47Z

/assign
/ok-to-test

@syedimam0012, is this good to go?
if so, would you mind rebasing?

I think so @maorfr
I've just rebased again.

maorfr · 2019-04-30T11:01:01Z

/lgtm

k8s-ci-robot · 2019-04-30T11:01:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr, syedimam0012

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~stable/chaoskube/OWNERS~~ [maorfr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* [stable/chaoskube] add option to choose log format Signed-off-by: Syed Imam <[email protected]> * [stable/chaoskube] bumping Chart and image versions Signed-off-by: Syed Imam <[email protected]> * [stable/chaoskube] Version bump Signed-off-by: Syed Imam <[email protected]>

linki · 2019-05-10T14:25:20Z

@syedimam0012 @marc-sensenich @maorfr Thank you!

* [stable/chaoskube] add option to choose log format Signed-off-by: Syed Imam <[email protected]> * [stable/chaoskube] bumping Chart and image versions Signed-off-by: Syed Imam <[email protected]> * [stable/chaoskube] Version bump Signed-off-by: Syed Imam <[email protected]>

helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2019

k8s-ci-robot requested review from linki and unguiculus January 30, 2019 03:55

syedimam0012 mentioned this pull request Jan 30, 2019

Adding JSON formatted log feature linki/chaoskube#120

Merged

syedimam0012 force-pushed the feature/structured-log-flag branch from 6984a20 to fd0eec8 Compare January 30, 2019 05:34

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2019

syedimam0012 force-pushed the feature/structured-log-flag branch from fd0eec8 to 17db727 Compare January 30, 2019 05:43

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2019

linki reviewed Jan 30, 2019

View reviewed changes

helm-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2019

syedimam0012 force-pushed the feature/structured-log-flag branch from dc62aff to 9a28f0e Compare February 1, 2019 05:45

marc-sensenich mentioned this pull request Feb 28, 2019

[stable/chaoskube] Utilize the podAnnotations for Prometheus scraping #11780

Merged

3 tasks

marc-sensenich reviewed Mar 13, 2019

View reviewed changes

k8s-ci-robot assigned maorfr Apr 22, 2019

k8s-ci-robot added the ok-to-test label Apr 22, 2019

syedimam0012 added 2 commits April 30, 2019 11:20

[stable/chaoskube] add option to choose log format

a799237

Signed-off-by: Syed Imam <[email protected]>

[stable/chaoskube] bumping Chart and image versions

66909a1

Signed-off-by: Syed Imam <[email protected]>

syedimam0012 force-pushed the feature/structured-log-flag branch from af35dd0 to 66909a1 Compare April 30, 2019 01:28

helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 30, 2019

[stable/chaoskube] Version bump

a76f5ed

Signed-off-by: Syed Imam <[email protected]>

syedimam0012 force-pushed the feature/structured-log-flag branch from 3928330 to a76f5ed Compare April 30, 2019 04:59

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 30, 2019

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019

k8s-ci-robot merged commit 8b9e72d into helm:master Apr 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/chaoskube] Feature/structured log flag #10986

[stable/chaoskube] Feature/structured log flag #10986

syedimam0012 commented Jan 30, 2019 •

edited

Loading

linki commented Jan 30, 2019

linki Jan 30, 2019

syedimam0012 Feb 1, 2019 •

edited

Loading

linki Feb 5, 2019

linki commented Feb 5, 2019

marc-sensenich commented Feb 19, 2019

marc-sensenich Mar 13, 2019

syedimam0012 Mar 26, 2019

maorfr commented Apr 22, 2019

syedimam0012 commented Apr 30, 2019

maorfr commented Apr 30, 2019

k8s-ci-robot commented Apr 30, 2019

linki commented May 10, 2019

[stable/chaoskube] Feature/structured log flag #10986

[stable/chaoskube] Feature/structured log flag #10986

Conversation

syedimam0012 commented Jan 30, 2019 • edited Loading

What this PR does / why we need it:

Special notes for your reviewer:

Checklist

linki commented Jan 30, 2019

linki Jan 30, 2019

Choose a reason for hiding this comment

syedimam0012 Feb 1, 2019 • edited Loading

Choose a reason for hiding this comment

linki Feb 5, 2019

Choose a reason for hiding this comment

linki commented Feb 5, 2019

marc-sensenich commented Feb 19, 2019

marc-sensenich Mar 13, 2019

Choose a reason for hiding this comment

syedimam0012 Mar 26, 2019

Choose a reason for hiding this comment

maorfr commented Apr 22, 2019

syedimam0012 commented Apr 30, 2019

maorfr commented Apr 30, 2019

k8s-ci-robot commented Apr 30, 2019

linki commented May 10, 2019

syedimam0012 commented Jan 30, 2019 •

edited

Loading

syedimam0012 Feb 1, 2019 •

edited

Loading