This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/rabbitmq] Reduce readiness/liveness probes frequency #10377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juan131 <[email protected]>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
|
/assign @tompizmor @desaintmartin |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juan131, tompizmor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| | `livenessProbe.timeoutSeconds` | number of seconds | 5 | | ||
| | `livenessProbe.periodSeconds` | number of seconds | 5 | | ||
| | `livenessProbe.timeoutSeconds` | number of seconds | 20 | | ||
| | `livenessProbe.periodSeconds` | number of seconds | 30 | |
There was a problem hiding this comment.
doesn't it miss the default values for readiness probes?
There was a problem hiding this comment.
You're right. Check this new PR: #10380
3 tasks
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
) Signed-off-by: juan131 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 [email protected]
What this PR does / why we need it:
Currently, readiness/liveness probes are executed every 5 seconds which is causing high CPU usage on certain clusters. This PR increases the timeoutSeconds & periodSeconds of these probes to reduce the frequency so they reduce the impact on the cluster performance.
Which issue this PR fixes
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]