Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: evaluate .ignore files during the change detection process #411

Closed

Conversation

philippwaller
Copy link

@philippwaller philippwaller commented Mar 15, 2022

What this PR does / why we need it:
This PR adds the ability to exclude files during the change detection process. This can be particularly useful in the context of version increment checks. If the feature is enabled, all .ctignore and .helmignore files inside the configured chart directories are evaluated by default and applied relative to the file path. All common glob patterns, including the globstar pattern **, are supported. In addition, the configuration parameter considered-dotignore-files can be adjusted to specify which .ignore files are to be considered.

Added config parameters (default values):

evaluate-dotignore-files: false
considered-dotignore-files:
    - .ctignore
    - .helmignore

Special notes for your reviewer: I added/modified test cases to cover the new functionality.

Signed-off-by: Philipp Waller [email protected]

@philippwaller
Copy link
Author

Dear Core Team,
do you have any feedback or change request regarding this PR? Thanks!

@johanneskastl
Copy link

Any updates on this? I would like to see this functionality, but seems like there was no reaction from the maintainers?

@philippwaller
Copy link
Author

I would be happy to revise the PR if the code is considered for future releases. Just let me know and I will make the necessary changes to ensure that the code is ready for integration.

@cpanato
Copy link
Member

cpanato commented May 4, 2023

This looks good, can we rebase and get this PR up-to-date, so we can run some manual tests? also will be good if you have a sample ci pipeline to show this working

thanks for working on this

@mavimo
Copy link

mavimo commented May 4, 2023

@philippwaller if you need support ping me, I'm available for testing, code review or any other think that can be useful 🙈

@lhriley
Copy link

lhriley commented Aug 2, 2023

Any updates on this work? It would be great to see this feature merged. 🥇

Copy link

github-actions bot commented Nov 9, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 9, 2023
@philippwaller
Copy link
Author

I will update this PR by end of next week. ✌️

@github-actions github-actions bot removed the Stale label Nov 10, 2023
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 25, 2023
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants