-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: evaluate .ignore files during the change detection process #411
feat: evaluate .ignore files during the change detection process #411
Conversation
Signed-off-by: Philipp Waller <[email protected]>
Signed-off-by: Philipp Waller <[email protected]>
6fac075
to
d48a436
Compare
Dear Core Team, |
Any updates on this? I would like to see this functionality, but seems like there was no reaction from the maintainers? |
I would be happy to revise the PR if the code is considered for future releases. Just let me know and I will make the necessary changes to ensure that the code is ready for integration. |
This looks good, can we rebase and get this PR up-to-date, so we can run some manual tests? also will be good if you have a sample ci pipeline to show this working thanks for working on this |
@philippwaller if you need support ping me, I'm available for testing, code review or any other think that can be useful 🙈 |
Any updates on this work? It would be great to see this feature merged. 🥇 |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
I will update this PR by end of next week. ✌️ |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
What this PR does / why we need it:
This PR adds the ability to exclude files during the change detection process. This can be particularly useful in the context of version increment checks. If the feature is enabled, all
.ctignore
and.helmignore
files inside the configured chart directories are evaluated by default and applied relative to the file path. All common glob patterns, including the globstar pattern**
, are supported. In addition, the configuration parameterconsidered-dotignore-files
can be adjusted to specify which.ignore
files are to be considered.Added config parameters (default values):
Special notes for your reviewer: I added/modified test cases to cover the new functionality.
Signed-off-by: Philipp Waller [email protected]