-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRS-1632 Add cadvisor #9
Conversation
startnow65
commented
May 12, 2021
- Fix Deprecation warnings
- Add cadvisor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common convention for role variables is to have them prefixed with the role name, in order to avoid possible variable conflicts with the other roles used in the same playbook.
Here we have prefixes:
dockerhost_
docker_
install_
cadvisor_
prometheus_
disable_
It can lead to conflicts. I guess renaming existing vars is not a good idea, but maybe stick to a constant prefix for the new variables?
Everything else is 👍
Rename new variables to have the role name as prefix
Thanks, updated |
Missed it in the last rename sweep