Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRS-1632 Add cadvisor #9

Merged
merged 9 commits into from
May 12, 2021
Merged

CRS-1632 Add cadvisor #9

merged 9 commits into from
May 12, 2021

Conversation

startnow65
Copy link
Contributor

  • Fix Deprecation warnings
  • Add cadvisor

harshal-shah
harshal-shah previously approved these changes May 12, 2021
Copy link
Contributor

@antonu17 antonu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common convention for role variables is to have them prefixed with the role name, in order to avoid possible variable conflicts with the other roles used in the same playbook.

Here we have prefixes:

  • dockerhost_
  • docker_
  • install_
  • cadvisor_
  • prometheus_
  • disable_

It can lead to conflicts. I guess renaming existing vars is not a good idea, but maybe stick to a constant prefix for the new variables?

Everything else is 👍

Rename new variables to have the role name as prefix
@startnow65
Copy link
Contributor Author

A common convention for role variables is to have them prefixed with the role name, in order to avoid possible variable conflicts with the other roles used in the same playbook.

Here we have prefixes:

  • dockerhost_
  • docker_
  • install_
  • cadvisor_
  • prometheus_
  • disable_

It can lead to conflicts. I guess renaming existing vars is not a good idea, but maybe stick to a constant prefix for the new variables?

Everything else is 👍

Thanks, updated

@startnow65 startnow65 merged commit 547d00d into master May 12, 2021
@startnow65 startnow65 deleted the patch/CRS-1632-add-cadvisor branch May 12, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants