Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for the specialized URDFs in the launchfile #83

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

hello-amal
Copy link
Collaborator

@hello-amal hello-amal commented Jul 22, 2024

Joint with stretch_install#77 and stretch_production_tools#24.

Although stretch_install#72 changed stretch_create_ament_workspace.sh to run prepare_specialized_urdf.py, that won't actually work since the URDFs don't get generated until after that script is run. As discussed with @hello-fazil and @hello-vinitha , this PR (and its joint PRs, above):

  1. Stops running prepare_specialized_urdf.py as part of creating the ROS2 workspace.
  2. Instead, adds instructions to run that script as part of the Python SDK QC process.
  3. Raises an exception in the web teleop launchfile if the URDFs don't exist, with instructions on how to create them.

Testing

  • Delete the URDFs, rebuild your workspace, run ros2 launch stretch_web_teleop web_interface.launch.py and verify it fails and tells you how to generate the URDFs.
  • Follow the instructions in the message, re-run ros2 launch stretch_web_teleop web_interface.launch.py, and verify it succeds.

@hello-amal hello-amal merged commit 7bc5cff into master Jul 24, 2024
1 check passed
@hello-amal hello-amal deleted the amaln/prepare_specialized_urdf branch July 24, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant