Add a certificate creation script #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to be merged before merging the PR hello-robot/stretch_install#75 |
hello-amal
approved these changes
Jul 10, 2024
| cd .. | ||
| touch .env | ||
| echo certfile=${HELLO_FLEET_ID}+6.pem >> .env | ||
| echo keyfile=${HELLO_FLEET_ID}+6-key.pem >> .env |
| @@ -2,6 +2,7 @@ | |||
| import pathlib | |||
| import pprint | |||
| import subprocess | |||
| import sys | |||
There was a problem hiding this comment.
You should rebase on top of master to eliminate this commit. (The reason this arises is the default merge strategy for this repo is Squash & Merge)
| @@ -0,0 +1,15 @@ | |||
| echo "Generating web interface certs..." | |||
| cd certificates | |||
There was a problem hiding this comment.
Now that we've moved this script to this repo, its possible that users will run it from a different folder (e.g., the workspace root). I'd recommend adding a check for whether the certificates director exists, as a heuristic for whether the user is in the stretch_web_teleop folder. If it does not exist, the script should echo a message telling users it must be run from stretch_web_teleop, and exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a script to create certificates for the web teleop, which was previously part of the create ament_ws script from the Stretch Install repository. This has the advantage of modularizing the certificate creation step. It can be maintained only in this one stake-holding repository and just called from Stretch Install scripts.
Testing procedure
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-filesTo merge
Squash & Merge