workflow: on_target: Reuse build workflow to build firmware #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balaji-srin
force-pushed
the
reuse_build_worklow_in_on_target_test
branch
4 times, most recently
from
199f4ad to
f7349eb
Compare
|
balaji-srin
force-pushed
the
reuse_build_worklow_in_on_target_test
branch
from
f7349eb to
854f9a6
Compare
balaji-srin
force-pushed
the
reuse_build_worklow_in_on_target_test
branch
3 times, most recently
from
cb9ea64 to
a9031f7
Compare
DematteisGiacomo
approved these changes
Jun 11, 2024
Previously the on_target workflow was re-doing the steps done by the build workflow. But since now the build workflow uploads the built firmware as artifacts, we now have the possibility to re-use it. The on_target workflow now calls the build worfklow and downloads its artifaacts to perform the tests. The test fraemwork code was modified to accept new input argument firmware-hex that points to the hex file to test. Also renamed the python file to have the test_ prefix so that pytest auto-detects it when invoked without any options. Signed-off-by: Balaji Srinivasan <[email protected]>
balaji-srin
force-pushed
the
reuse_build_worklow_in_on_target_test
branch
from
a9031f7 to
3702a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the on_target workflow was re-doing the steps done by the build workflow. But since now the build workflow uploads the built firmware as artifacts, we now have the possibility to re-use it. The on_target workflow now calls the build worfklow and downloads its artifaacts to perform the tests.
The test fraemwork code was modified to accept new input argument firmware-hex that points to the hex file to test.