modules: Handle desired configurations #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensrostad
force-pushed
the
add/confighandling
branch
3 times, most recently
from
9c458a3 to
51743aa
Compare
simensrostad
changed the title
simensrostad
force-pushed
the
add/confighandling
branch
4 times, most recently
from
37657be to
904c73a
Compare
balaji-srin
reviewed
Jun 3, 2024
balaji-srin
reviewed
Jun 3, 2024
balaji-srin
reviewed
Jun 3, 2024
|
Also remove simple config module? |
simensrostad
force-pushed
the
add/confighandling
branch
5 times, most recently
from
528cebe to
23d8c25
Compare
Ill wait a bit before I remove it, I intend to iterate on the config stuff. Just to be completely sure we don't need it. |
simensrostad
force-pushed
the
add/confighandling
branch
from
23d8c25 to
89a61bf
Compare
Handle desired configurations set in the shadow: - Add cddl schema for configurations set in the shadow - Add configuration channel that interested modules can subscribe to - Enable PWM and set RGB values according to the shadow configurations - Update trigger module to only use system workqueue, this is ok since we are not blocking the system workqueue for long periods of time and its simplifies the module quite a bit. - The trigger will only run as long as we are connected. Missing: - Adopting gnss enable. This depends on GNSS being sent internally from the location module. Signed-off-by: Simen S. Røstad <[email protected]>
simensrostad
force-pushed
the
add/confighandling
branch
from
89a61bf to
ed16a3d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle desired configurations set in the shadow:
since we are not blocking the system workqueue for long periods of
time and its simplifies the module quite a bit.
Missing:
from the location module.