Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PureScript's new spago.yaml configs #9362

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jbrudvik
Copy link
Contributor

PureScript's rewritten package manager / build system, spago@next, has moved from spago.dhall to spago.yaml config files.

When purescript-language-server is launched in a directory that does not appear to be a PureScript (spago) project, it tries to ask the user to resolve this issue. In Helix, this causes purescript-language-server to exit immediately:

2024-01-16T22:47:18.699 helix_lsp::transport [ERROR] purescript-language-server err <- "ResponseError: Method not found: window/showMessageRequest\n"

This change adds support for new spago.yaml config files as PureScript project roots, which enables purescript-language-server to launch without issue for spago@next projects.

PureScript's rewritten package manager / build system, spago@next, uses spago.yaml config files instead of spago.dhall.

https://discourse.purescript.org/t/announcing-spago-next-a-purescript-rewrite-registry-support-and-more/3737
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jan 17, 2024
@archseer archseer merged commit f41727c into helix-editor:master Jan 17, 2024
6 checks passed
hamrik pushed a commit to hamrik/helix that referenced this pull request Jan 27, 2024
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants