Add insert-final-newline config option
#8157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves helix-editor#4274 with the implementation largely based off of helix-editor#5435 and also addresses the review from @the-mikedavis on that PR. The option name is from EditorConfig's `insert_final_newline`, which is also used by VS Code as `files.insertFinalNewline`. We match Vim's behavior in that :w will add the newline to unmodified files but :wa will not; see helix-editor#1760. Tests are included for this. Co-authored-by: Xalfer <[email protected]>
Makes the failure message easier to read
More discoverable and consistent with rest of docs and codebase Co-authored-by: Michael Davis <[email protected]>
zqianem
force-pushed
the
insert_final_newline
branch
from
2d4c59a
to
4e7a86c
Compare
pascalkuthe
reviewed
Sep 10, 2023
pascalkuthe
added
E-easy
zqianem
force-pushed
the
insert_final_newline
branch
from
add769f
to
81c69f9
Compare
pascalkuthe
previously approved these changes
Sep 10, 2023
pascalkuthe
added
S-waiting-on-review
pascalkuthe
added
S-waiting-on-author
pascalkuthe
previously approved these changes
Sep 11, 2023
pascalkuthe
added
S-waiting-on-review
|
Oh I forgot to call |
Includes fixes for integration test failures cause by new default
zqianem
force-pushed
the
insert_final_newline
branch
from
a3675dd
to
453a486
Compare
pascalkuthe
approved these changes
Sep 11, 2023
the-mikedavis
approved these changes
Sep 12, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Xalfer <[email protected]>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Co-authored-by: Xalfer <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Co-authored-by: Xalfer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #4274 with the implementation largely based off of #5435
and also addresses the review from @the-mikedavis on that PR.
The option name is from EditorConfig's
insert_final_newline, which isalso used by VS Code as
files.insertFinalNewline.We match Vim's behavior in that :w will add the newline to unmodified
files but :wa will not; see #1760. Tests are included for this.
Co-authored-by: Xalfer [email protected]