Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python constant identifier highlight #6751

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix python constant identifier highlight #6751

merged 1 commit into from
Apr 14, 2023

Conversation

LowLevelLover
Copy link
Contributor

  • Fix: python query highlight now support single-character and alphanumeric constant identifier.

Merging this PR would close #6730 issue.

pascalkuthe
pascalkuthe approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I actually changed my mind about leading underscores. Since leading underscores are commonly used for privates in python it probably still makes sense to highlight those as constants 👍

@pascalkuthe pascalkuthe added C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Apr 14, 2023
@archseer archseer merged commit bb27542 into helix-editor:master Apr 14, 2023
@LowLevelLover LowLevelLover deleted the fix/python-constant-highlight branch May 6, 2023 17:37
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@LowLevelLover @Triton171
Fix python highlights to support single character and alphanumeric co…
3ec6aba 
…nstant identifier (helix-editor#6751)
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@LowLevelLover @wes-adams
Fix python highlights to support single character and alphanumeric co…
884edad 
…nstant identifier (helix-editor#6751)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@LowLevelLover
Fix python highlights to support single character and alphanumeric co…
eeabef3 
…nstant identifier (helix-editor#6751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird Python highlighting
3 participants
@LowLevelLover @pascalkuthe @archseer