normalize LSP workspaces #6517
Merged
normalize LSP workspaces #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
| @@ -201,6 +202,7 @@ impl Client { | |||
| let (server_rx, server_tx, initialize_notify) = | |||
| Transport::start(reader, writer, stderr, id); | |||
| let (workspace, workspace_is_cwd) = find_workspace(); | |||
| let workspace = path::get_normalized_path(&workspace); | |||
There was a problem hiding this comment.
What do you think about canonicalizing in find_workspace instead?
There was a problem hiding this comment.
I wanted to do that at first but the problem with that is the normalize is in helix-core and find_workspace is in helix-loader (which can't pull in helix-core). All other uses of find_workspace don't care about path equality (they just use it to do IO where it doesn't matter which path is used)
the-mikedavis
approved these changes
Mar 31, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6505
We didn't normalize/canoncialize LSP workspace paths with can both lead to bugs in the workspace detection and leads to inconsistent paths being sent to the LS which might not handle this correctly.