Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor completion doc popup and fix positioning #5842

Merged
merged 5 commits into from
Feb 11, 2023
Merged

Refactor completion doc popup and fix positioning #5842

merged 5 commits into from
Feb 11, 2023

Commits on Feb 5, 2023

  1. Use early return in rendering completion doc

    @sudormrfbin
    sudormrfbin committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    853514c View commit details
    Browse the repository at this point in the history

  2. Rename completion doc popup area variables

    @sudormrfbin
    sudormrfbin committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    f1957ff View commit details
    Browse the repository at this point in the history

  3. Refactor our Markdown construction in completion doc

    @sudormrfbin
    sudormrfbin committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2d9d638 View commit details
    Browse the repository at this point in the history

  4. Create popup rect instead of using raw values

    @sudormrfbin
    sudormrfbin committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2d551bf View commit details
    Browse the repository at this point in the history

  5. Fix completion doc popup area calculation logic 

    Earlier the doc popup would draw over the compeltion popup
itself and sometimes over the cursor too.
    @sudormrfbin
    sudormrfbin committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    7cbf2be View commit details
    Browse the repository at this point in the history