Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sagemath language #5649

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Support sagemath language #5649

merged 2 commits into from
Jan 23, 2023

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Jan 23, 2023

Hi this is my first contribution to this project. I copied the structure from: #2903

The goal of this PR is to add support for the sagemath language.

  • The syntax is based on python.
  • I didn't succeed at running the python language server by default with .sage files.
  • It would be nice if the syntax highlighting supported sage's docstrings: In a comment, the lines starting with sage: contain sage code. It would be nice if its syntax were highlighted. For an example of a docstring, see: https://doc.sagemath.org/html/en/developer/coding_basics.html#template

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jan 23, 2023
@the-mikedavis
Copy link
Member

Could you run cargo xtask docgen and commit the results? That will add sage to the supported language documentation

@the-mikedavis the-mikedavis changed the title support sagemath language Support sagemath language Jan 23, 2023
@the-mikedavis the-mikedavis merged commit 7e191f5 into helix-editor:master Jan 23, 2023
@Eloitor Eloitor mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eloitor @the-mikedavis