Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relative numbers #485

Merged
merged 10 commits into from
Aug 16, 2021
Merged

feat: relative numbers #485

merged 10 commits into from
Aug 16, 2021

Conversation

gbaranski
Copy link
Contributor

@gbaranski gbaranski commented Jul 22, 2021

closes #483

@gbaranski
Copy link
Contributor Author

I'm not sure how I can pass misc configuration to render_buffer, do you have any ideas? render_buffer member of EditorView struct, which has keymaps field, maybe we could replace it with config: Config which has config.keymaps, or add another field called misc_config: MiscConfig?

@archseer
Copy link
Member

I was thinking that maybe the config type could be moved to helix-view then placed onto editor.config. That way it's not term specific and you can access it from anywhere you have access to the Editor.

Themes already work that way for example.

@pickfire
Copy link
Contributor

I think we could put part of the config within editor, I don't think we should have a single config for everything unless we are thinking of live patching config like alacritty.

@archseer
Copy link
Member

archseer commented Aug 8, 2021

I've added an [editor] config section that gets passed into Editor: a2ccfff should be enough to unblock this PR.

@gbaranski gbaranski marked this pull request as ready for review August 10, 2021 19:45
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
@gbaranski gbaranski requested a review from archseer August 11, 2021 15:26
@archseer archseer merged commit 7892349 into helix-editor:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative line numbers
3 participants