Fix closing buffer with custom keymap #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
A-Walrus
force-pushed
the
fix_custom_keymap_close
branch
from
b9a0ae5
to
4627f01
Compare
erasin
added a commit
to erasin/helix
that referenced
this pull request
Sep 1, 2022
A-Walrus
force-pushed
the
fix_custom_keymap_close
branch
from
4627f01
to
7e8a370
Compare
archseer
reviewed
Sep 1, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* Fix closing buffer with custom keymap * Add comment explaining if
jdrst
pushed a commit
to jdrst/helix
that referenced
this pull request
Sep 13, 2022
* Fix closing buffer with custom keymap * Add comment explaining if
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
* Fix closing buffer with custom keymap * Add comment explaining if
pascalkuthe
added a commit
that referenced
this pull request
Jan 8, 2024
This change effectively reverts #3508 and #3633. When a view is changed we must make history commits (and ensure that the cursor is in view) for the newly focused view. Not the old view. These changes were originally introduced to fix mode switch hooks. However, the mode switch hooks have been moved elsewhere so that concern doesn't apply anymore. In particular, because modes are now editor wide and not per view and also because view switches now always reset the editor back to normal mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3626