Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gutters on config-reload and :set gutters #3457

Closed
wants to merge 2 commits into from

Conversation

A-Walrus
Copy link
Contributor

Resolves #3445

@archseer
Copy link
Member

Hmm, since each view has it's own set of gutters the idea was you could use :set per view to change gutters. Do we have access to the old config value? Then we could only update buffers that have the old default set of gutters.

@A-Walrus
Copy link
Contributor Author

A-Walrus commented Aug 17, 2022

the idea was you could use :set per view to change gutters.

This feels kind of counter intuitive to me. If the :set command is defined as setting a config option, it should be equivalent to reloading with a changed config. Having it act on a specific view for only this specific option seems like inconsistent behavior. Maybe there should be a separate command for per-view changes?

@kirawi kirawi added C-bug Category: This is a bug A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Sep 13, 2022
@A-Walrus A-Walrus changed the title Update gutters on config-reload Update gutters on config-reload and :set gutters Oct 4, 2022
@pascalkuthe
Copy link
Member

closing this one as stale, this will be covered by #8853. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config-reload doesn't apply changes in editor.gutters settings
4 participants