Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme: add papercolor light #3426

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

uncomfyhalomacro
Copy link
Contributor

@n0s4
Copy link
Contributor

n0s4 commented Aug 14, 2022

Do you want to add some of the markup scopes? There is no highlighting for markdown files.

@uncomfyhalomacro
Copy link
Contributor Author

i will. me will ping once PR is ready. sorry for the incompleteness of the PR. 😅

@uncomfyhalomacro
Copy link
Contributor Author

Do you want to add some of the markup scopes? There is no highlighting for markdown files.

Added 😄 thankies! PR ready for review

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

"operator" = { fg = "regular4", modifiers = ["bold"]}

"label" = { fg = "selection_background", modifiers = ["bold", "italic"] }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is also missing diff colors, but either way I will merge for now.

@pickfire pickfire merged commit c18b542 into helix-editor:master Aug 17, 2022
@the-mikedavis
Copy link
Member

@uncomfyhalomacro could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@uncomfyhalomacro
Copy link
Contributor Author

@uncomfyhalomacro could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

added. ❤️

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants