Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Related Fixes #3412

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Theme Related Fixes #3412

merged 2 commits into from
Aug 14, 2022

Conversation

n0s4
Copy link
Contributor

@n0s4 n0s4 commented Aug 13, 2022

  • Replace "text" with "ui.text" in rose_pine* themes
  • Change "attributes" to "attribute" in many included themes
  • Document "attribute", "property" and "punctuation.special" in the theme section of the book.
  • Remove "variable.function" from the documentation: it doesn't appear to exist in any highlights.scm.
  • Remove "path" from snazzy; maybe it should be string.special.path?

@n0s4
Theme Related Fixes
6eb9032 
- Replace "text" with "ui.text" in rose_pine* themes
- Change "attributes" to "attribute" in many included themes
- Document "attribute", "property" and "punctuation.special" in the theme section of the book.
- Remove "variable.function" from the documentation: it doesn't appear to exist in any highlights.scm.
- Remove "path" from snazzy; maybe it should be string.special.path?
@the-mikedavis
Copy link
Member

In most cases we translate property/field to variable.other.member. I think the current @property capture for regex is an oversight - looking at that now I think it should be @label.

For snazzy, yeah I bet that was meant to be string.special.path. It may have successfully been matching that scope before #3275 and should be updated now

@n0s4
Add back string.special.path to replace path in snazzy
a06fb39 
Also change @Property to @Label in regex highlights.
All themes that had "property" had "label" as well so I removed
property from them and let the label scope cover it since there
are no longer any captures for @Property.
Removed "property" from the theme docs as well.
@n0s4
Copy link
Contributor Author

n0s4 commented Aug 14, 2022

Ok. I changed @property to @label in regex/highlights.scm. Since that was the only instance of @property and every theme that had property also included label, I've removed property from each theme and let label cover it.

Also added string.special.path back to snazzy with the same colour as path had before.

@the-mikedavis the-mikedavis merged commit c5deb30 into helix-editor:master Aug 14, 2022
@the-mikedavis
Copy link
Member

Thanks @n0s4!

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
@n0s4 @AlexanderBrevig
Theme Related Fixes (helix-editor#3412)
969469f
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@n0s4 @thomasskk
Theme Related Fixes (helix-editor#3412)
ba808aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n0s4 @the-mikedavis