Fix comment #3334
Merged
Fix comment #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helix-view/src/document.rs
Outdated
| @@ -576,7 +576,7 @@ impl Document { | |||
| } | |||
|
|
|||
| /// Detect the indentation used in the file, or otherwise defaults to the language indentation | |||
| /// configured in `languages.toml`, with a fallback to 4 space indentation if it isn't | |||
| /// configured in `languages.toml`, with a fallback to the default indentation if it isn't | |||
There was a problem hiding this comment.
This should either say what the default value is ("tabs") or link to DEFAULT_INDENT
There was a problem hiding this comment.
Hmm. Had issues linking the variable, so went with "tabs". It was complaining that it was private, but then still complained when I ran with the respective flag.
the-mikedavis
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
literally just fixing a comment that become incorrect due to a change made for pr #3095