New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to avoid panicking on ill-formed LSP messages #306

Closed

malte-v wants to merge 1 commit into helix-editor:master from malte-v:lsp-crash-fix

Contributor

malte-v commented Jun 18, 2021

See #33 (comment)


          Add check to avoid panics on ill-formed LSP messages

858545d

malte-v mentioned this pull request

Issues with pyls #33

Closed

Contributor

vv9k commented Jun 18, 2021 •

edited

Loading

#287 seems to already solve this by not unwraping on non existent values

https://github.com/helix-editor/helix/pull/287/files#diff-9e9304a3d988b4d0a785b2f661a0bbc448011588b825d053ff4805b6b10df889L100

Contributor Author

malte-v commented Jun 18, 2021

Ah ok, let's then merge your PR.

malte-v closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet