Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight whole row in picker menus #2939

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

ChrHorn
Copy link
Contributor

@ChrHorn ChrHorn commented Jul 1, 2022

This is for themes that use bg to highlight the selection in picker menus.
Makes it easier to navigate, looks cleaner, and is in line with the style of the autocomplete menu.

before:
image

after:
image

Not 100% sure if this is still needed:

} else if is_active {
selected.patch(span.style)

Copy link
Member

@sudormrfbin sudormrfbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sudormrfbin sudormrfbin changed the title highlight whole row in picker menus Highlight whole row in picker menus Jul 2, 2022
@sudormrfbin sudormrfbin merged commit 9f43dbc into helix-editor:master Jul 2, 2022
@ChrHorn ChrHorn deleted the picker-selection branch July 2, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants