Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single width left margin for completion popup #2728

Merged
merged 2 commits into from
Jun 26, 2022

Commits on Jun 9, 2022

  1. Configuration menu
    Copy the full SHA
    31cf6c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Clear with ui.menu style before rendering menu

    When rendering a completion popup, the popup component will clear
    the area with ui.popup and then the menu component would draw over
    it using a table component. We remove the left edge of the area
    before passing it to the table component (so that it will be left
    as padding), and the table component uses ui.menu as the style.
    If ui.menu and ui.popup are different the left edge of the popup
    will look different from the rest of the popup. We avoid this by
    clearing the whole area with ui.menu in Menu::render
    sudormrfbin committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    23bc196 View commit details
    Browse the repository at this point in the history