feat(commands): add log-open command #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clear up that ❌ from the Docs CI, you can run |
pickfire
reviewed
May 9, 2022
| @@ -63,5 +63,6 @@ | |||
| | `:tree-sitter-subtree`, `:ts-subtree` | Display tree sitter subtree under cursor, primarily for debugging queries. | | |||
| | `:config-reload` | Refreshes helix's config. | | |||
| | `:config-open` | Open the helix config.toml file. | | |||
| | `:log-open` | Open the helix log file. | | |||
There was a problem hiding this comment.
I am not aware if this is from other editors? Why do we want to do this rather something like variable $VIMRUNTIME?
There was a problem hiding this comment.
I'd prefer this too, but we'd need to add support for variables. Once we do we'll remove these commands
There was a problem hiding this comment.
I am not aware if this is from other editors? Why do we want to do this rather something like variable
$VIMRUNTIME?
IMO, as the "post-modern" editor, I think Helix's point is exactly to have some features that other editors doesn't have.
Although read it from a variable is pretty handy too!
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first small contribution to an open source project.
I hope that all is in order.
Implements #2418