Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace constant.number with constant.numeric #2389

Merged
merged 1 commit into from
May 4, 2022

Conversation

ChrHorn
Copy link
Contributor

@ChrHorn ChrHorn commented May 4, 2022

There were 2 instances of constant.number in the codebase. Should be constant.numeric instead.

@ChrHorn
Copy link
Contributor Author

ChrHorn commented May 4, 2022

@workingj
Don't think the constant.number fields had any effect. Let me know if the they should replace the constant.numeric values or just keep it this way.

Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this was unintended 👍🏻

@archseer archseer merged commit 5ab669f into helix-editor:master May 4, 2022
@ChrHorn ChrHorn deleted the number branch May 4, 2022 07:51
@workingj
Copy link
Contributor

workingj commented May 4, 2022

@workingj
Don't think the constant.number fields had any effect. Let me know if the they should replace the constant.numeric values or just keep it this way.

@ChrHorn
thx, i was not aware of this. w'll see if this comes up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants