Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lang): add nushell language support #2225

Merged
merged 6 commits into from
Apr 22, 2022
Merged

feat(lang): add nushell language support #2225

merged 6 commits into from
Apr 22, 2022

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented Apr 22, 2022 •
edited
Loading

Try to add nushell language support

@the-mikedavis
Copy link
Member

To clear up the ❌ from the Docs CI you'll need to run cargo xtask docgen and commit the results

@hustcer
Copy link
Contributor Author

hustcer commented Apr 22, 2022

To clear up the ❌ from the Docs CI you'll need to run cargo xtask docgen and commit the results

Thanks, updated

the-mikedavis
the-mikedavis requested changes Apr 22, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes but this is looking good so far 👍

languages.toml Outdated Show resolved Hide resolved
runtime/queries/nu/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/nu/injections.scm Outdated Show resolved Hide resolved
@hustcer
Copy link
Contributor Author

hustcer commented Apr 22, 2022

Thanks, all fixed

the-mikedavis
the-mikedavis approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for working on this!

@the-mikedavis the-mikedavis merged commit 5c25705 into helix-editor:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcer @the-mikedavis