Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tree-sitter for .zshenv and zsh files #1574

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Enable tree-sitter for .zshenv and zsh files #1574

merged 1 commit into from
Jan 24, 2022

Conversation

EricCrosson
Copy link
Contributor

@EricCrosson EricCrosson commented Jan 24, 2022 •
edited
Loading

This commit builds on #1460, #1571, and others, adding the .zshenv
file and all files with the zsh extension to the file-types using
bash syntax-highlighting.

Before:

  • .zshenv
    image
  • a non-special .zsh file
    image

After:

  • .zshenv
    image
  • a non-special .zsh file
    image

@EricCrosson EricCrosson marked this pull request as ready for review January 24, 2022 11:29
@Omnikar
Copy link
Contributor

Omnikar commented Jan 24, 2022

Add .zprofile in as well. And there might be others I don't know of.

@EricCrosson
Copy link
Contributor Author

Add .zprofile in as well. And there might be others I don't know of.

If we want this to be a comprehensive list there's also zlogin and zlogout https://gist.github.com/philoserf/b797d42dbf31bdb7e313

@Omnikar
Copy link
Contributor

Omnikar commented Jan 24, 2022

Are there more for bash as well?

@EricCrosson
Copy link
Contributor Author

EricCrosson commented Jan 24, 2022 •
edited
Loading

Are there more for bash as well?

I'm not sure -- smells like its outside of my proficiency and the scope of PR 🙂

@EricCrosson
Copy link
Contributor Author

Ah, found this list. We were close, one more diff incoming

@EricCrosson
Enable tree-sitter for .zshenv and zsh files
bec4316 
This commit builds on helix-editor#1460, helix-editor#1571, and others, adding the .zshenv
file and all files with the zsh extension to the file-types using
bash syntax-highlighting.
pickfire
pickfire approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this should be good for now, shouldn't block addition for this I think.

@pickfire pickfire merged commit 0ad7561 into helix-editor:master Jan 24, 2022
@EricCrosson EricCrosson deleted the enable-tree-sitter-for-zshenv branch January 24, 2022 15:51
@irevoire
Copy link
Contributor

Thanks! Super cool I had no time to finish my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricCrosson @Omnikar @irevoire @pickfire