-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands): command palette #1400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this can be done later on, but take a look at how the completion helix/helix-term/src/ui/menu.rs Lines 16 to 22 in 0dab6c8
Most components would then have to use some default implementation that only exposes a single row. |
(There's an old TODO here to actually implement the picker list via Menu too but it's possible the components have diverged too much now helix/helix-term/src/ui/menu.rs Lines 44 to 45 in 0dab6c8
|
I'd love to have this functionality -- what's the current state? |
@heliostatic I went down the rabbit hole of
But didn't have time to finish it yet. |
I'll merge this as is and we can work on the improvement in a follow-up. Can you fix the conflicts? |
@archseer done, sorry for taking so long with this PR, I sadly don't have much time lately. |
@archseer suggestions applied and issues fixed. |
Sorry, one more rebase! I merged the debugger branch so there's some conflicts. |
Add new command to display command pallete that can be used to discover and execute available commands. Fixes: #559
@archseer done ✅ |
Thanks for the patience! 🎉 |
Add new command to display command pallete that can be used
to discover and execute available commands.
Fixes: #559