Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error when formatter is not available #12183

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

doriath
Copy link
Contributor

@doriath doriath commented Dec 3, 2024

Fixes #6736.

Before when user run :fmt command, but no formatter was available, there was no feedback which was confusing to the users.

helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved
helix-term/tests/test/commands/write.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added the A-command Area: Commands label Dec 3, 2024
the-mikedavis added a commit that referenced this pull request Dec 3, 2024
Sometimes we used "LSP" to mean "language server". This change
eliminates the improper "LSP" usage.

Ref #12183 (comment)
@doriath doriath force-pushed the format-error branch 3 times, most recently from b7c70fe to af30e2b Compare December 4, 2024 06:40
Fixes helix-editor#6736.

Before when user run :fmt command, but no formatter was available, there
was no feedback which was confusing to the users.
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis changed the title Show an error when formatter is not available. Show an error when formatter is not available Dec 4, 2024
@the-mikedavis the-mikedavis merged commit 7a2afdc into helix-editor:master Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be an error when formating fails
3 participants