Cleanup clients after event loop, not on drop

helix-editor · Jun 18, 2021 · 55d728f · 55d728f
1 parent 1a326cb
commit 55d728f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/helix-lsp/src/client.rs b/helix-lsp/src/client.rs
@@ -8,7 +8,6 @@ use jsonrpc_core as jsonrpc;
 use lsp_types as lsp;
 use serde_json::Value;
 use std::future::Future;
-use std::ops::Drop;
 use std::process::Stdio;
 use std::sync::atomic::{AtomicU64, Ordering};
 use tokio::{
@@ -26,12 +25,6 @@ pub struct Client {
     offset_encoding: OffsetEncoding,
 }
 
-impl Drop for Client {
-    fn drop(&mut self) {
-        let _ = crate::block_on(self.force_shutdown());
-    }
-}
-
 impl Client {
     pub fn start(cmd: &str, args: &[String]) -> Result<(Self, UnboundedReceiver<Call>)> {
         let process = Command::new(cmd)

diff --git a/helix-lsp/src/lib.rs b/helix-lsp/src/lib.rs
@@ -273,6 +273,10 @@ impl Registry {
             Err(Error::LspNotDefined)
         }
     }
+
+    pub fn iter_clients(&self) -> impl Iterator<Item = &Arc<Client>> {
+        self.inner.values()
+    }
 }
 
 // REGISTRY = HashMap<LanguageId, Lazy/OnceCell<Arc<RwLock<Client>>>

diff --git a/helix-term/src/application.rs b/helix-term/src/application.rs
@@ -22,7 +22,8 @@ use crossterm::{
 
 use tui::layout::Rect;
 
-use futures_util::stream::FuturesUnordered;
+use futures_util::{future, stream::FuturesUnordered};
+
 use std::pin::Pin;
 
 type BoxFuture<T> = Pin<Box<dyn Future<Output = T> + Send>>;
@@ -331,6 +332,14 @@ impl Application {
 
         self.event_loop().await;
 
+        future::join_all(
+            self.editor
+                .language_servers
+                .iter_clients()
+                .map(|client| client.force_shutdown()),
+        )
+        .await;
+
         // reset cursor shape
         write!(stdout, "\x1B[2 q");