Adopt cleaner solution to the make/gnumake conflict. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1: Rename Makefile -> GNUmakefile Adopt a solution to the problem where the system "make" utility is not a GNU-compatible variant by taking advantage of the way GNU Make searches for its Makefile differently from traditional (AT&T V7) make and redirecting the build process to use "gmake", which is the conventional name for GNU Make on such platforms.
Part 2: New Makefile, restore rebar.config.
|
How are we feeling about this one? Go, no go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits fixes builds on platforms in which "make" is not GNU-compatible. It uses the scheme that we've resolved to use for
blockchain-core, which preserves the commit history for the Makefile and simultaneously reduces long-term maintenance ofrebar.config.See helium/blockchain-core#989 for the full conversation and resolution.