Define custom regions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2022 12:21
ke6jjj
approved these changes
Jan 3, 2023
|
you ready for this to be reviewed/merged @mikev ? if so pull it out of Draft |
|
We've got about 7 pulls that should be reviewed together, first, @madninja |
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement:
Often a country or several countries need a custom region, which defines slightly different parameters. For example in Malaysia any frequencies in 924 Mhz are not legal.
Solution:
So we defined a new region AS923_1B which did not use frequency within 924 Mhz. Now Kenya needs this same custom region, because some of our EU868 frequencies are not legal. This will be a recurring pattern. The PR, review, commit process is painful so lets just do this once across all our repos and define EU868_A to _F and AS923_1A .. 1F
Only AS923 and EU868 will require custom regions.
Libraries (Require a review 1st)
#250
helium/blockchain-core#1502
helium/erlang-lorawan#27
Projects
helium/miner#1873
https://github.com/helium/gateway-rs/search?q=as923 [gateway-rs no longer requires enum]
helium/sx1302_hal#36
https://github.com/helium/docs/pull/1048/files
helium/helium-config-service#27 (edited)