Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable metrics tests #35

Merged
merged 1 commit into from
Sep 12, 2022
Merged

disable metrics tests #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions smoke-tests/src/test/groovy/io/opentelemetry/smoketest/PrometheusSmokeTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
package io.opentelemetry.smoketest

import io.opentelemetry.testing.internal.armeria.client.WebClient
import spock.lang.Ignore

import java.time.Duration
import spock.lang.IgnoreIf

Expand Down Expand Up @@ -33,6 +35,7 @@ class PrometheusSmokeTest extends SmokeTest {
return [PROMETHEUS_PORT]
}

@Ignore // We've disabled the metrics provider
def "Should export metrics"(int jdk) {
setup:
startTarget(jdk)
Expand Down
12 changes: 6 additions & 6 deletions smoke-tests/src/test/groovy/io/opentelemetry/smoketest/SpringBootSmokeTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ class SpringBootSmokeTest extends SmokeTest {
.collect(toSet())
loggedTraceIds == spanTraceIds

then: "JVM metrics are exported"
def metrics = new MetricsInspector(waitForMetrics())
metrics.hasMetricsNamed("process.runtime.jvm.memory.init")
metrics.hasMetricsNamed("process.runtime.jvm.memory.usage")
metrics.hasMetricsNamed("process.runtime.jvm.memory.committed")
metrics.hasMetricsNamed("process.runtime.jvm.memory.limit")
// then: "JVM metrics are exported"
// def metrics = new MetricsInspector(waitForMetrics())
// metrics.hasMetricsNamed("process.runtime.jvm.memory.init")
// metrics.hasMetricsNamed("process.runtime.jvm.memory.usage")
// metrics.hasMetricsNamed("process.runtime.jvm.memory.committed")
// metrics.hasMetricsNamed("process.runtime.jvm.memory.limit")

cleanup:
stopTarget()
Expand Down