Merge pull request #35 from helios/disable_metrics_tests

disable metrics tests
helios · Sep 12, 2022 · 10b4ce6 · 10b4ce6
2 parents 50c978f + 77e3202
commit 10b4ce6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/smoke-tests/src/test/groovy/io/opentelemetry/smoketest/PrometheusSmokeTest.groovy b/smoke-tests/src/test/groovy/io/opentelemetry/smoketest/PrometheusSmokeTest.groovy
@@ -6,6 +6,8 @@
 package io.opentelemetry.smoketest
 
 import io.opentelemetry.testing.internal.armeria.client.WebClient
+import spock.lang.Ignore
+
 import java.time.Duration
 import spock.lang.IgnoreIf
 
@@ -33,6 +35,7 @@ class PrometheusSmokeTest extends SmokeTest {
     return [PROMETHEUS_PORT]
   }
 
+  @Ignore // We've disabled the metrics provider
   def "Should export metrics"(int jdk) {
     setup:
     startTarget(jdk)

diff --git a/smoke-tests/src/test/groovy/io/opentelemetry/smoketest/SpringBootSmokeTest.groovy b/smoke-tests/src/test/groovy/io/opentelemetry/smoketest/SpringBootSmokeTest.groovy
@@ -75,12 +75,12 @@ class SpringBootSmokeTest extends SmokeTest {
       .collect(toSet())
     loggedTraceIds == spanTraceIds
 
-    then: "JVM metrics are exported"
-    def metrics = new MetricsInspector(waitForMetrics())
-    metrics.hasMetricsNamed("process.runtime.jvm.memory.init")
-    metrics.hasMetricsNamed("process.runtime.jvm.memory.usage")
-    metrics.hasMetricsNamed("process.runtime.jvm.memory.committed")
-    metrics.hasMetricsNamed("process.runtime.jvm.memory.limit")
+//    then: "JVM metrics are exported"
+//    def metrics = new MetricsInspector(waitForMetrics())
+//    metrics.hasMetricsNamed("process.runtime.jvm.memory.init")
+//    metrics.hasMetricsNamed("process.runtime.jvm.memory.usage")
+//    metrics.hasMetricsNamed("process.runtime.jvm.memory.committed")
+//    metrics.hasMetricsNamed("process.runtime.jvm.memory.limit")
 
     cleanup:
     stopTarget()