Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.5: gRPC compatiblity fixes #9559

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

barchetta
Copy link
Member

Backport #9505 to Helidon 4.1.5

Description

  • Special handling for identity compressor to ensure compress flag is not turned on. Identity compression is a special case, and for compatibility it should not be treated as a normal compressor.
  • If a gRPC service is not found, include ":status" header in response to comply with gRPC spec
  • A few null checks were missing in GrpcRouteHandler
  • New tests for all the changes above
  • Fixes issue No grpc reponse from Javascript client request #9452

Documentation

None

- Special handling for identity compressor to ensure compress flag is not turned on. Identity compression is a special case, and for compatibility it should not be treated as a normal compressor.
- If a gRPC service is not found, include ":status" header in response to comply with gRPC spec
- A few null checks were missing in GrpcRouteHandler
- New tests for all the changes above
@barchetta barchetta added grpc backport Issues that are merged into a single branch, but missing in either master or previous release 4.x Version 4.x labels Dec 4, 2024
@barchetta barchetta self-assigned this Dec 4, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 4, 2024
@barchetta barchetta mentioned this pull request Dec 4, 2024
11 tasks
@barchetta barchetta added this to the 4.1.5 milestone Dec 4, 2024
@barchetta barchetta merged commit b30b099 into helidon-io:helidon-4.1.x Dec 4, 2024
44 checks passed
@barchetta barchetta deleted the 4.1.5-9505-backport branch December 4, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x backport Issues that are merged into a single branch, but missing in either master or previous release grpc OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants