-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows the creation of empty SSE events #9207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine to me, although I do have one question.
I see the writer of the issue cited the SSE spec saying that "empty" events are legal.
I know very little about SSE, but is it in any way a potential problem that the SseEvent
data for an empty event would contain this special constant value (as opposed to having no value at all)? For example, does this distort some representation of the event size or length or something like that that could otherwise be used to infer an "empty" event?
The code in |
Yes. Thanks. |
…nt SseEvent.NO_DATA to avoid returning null in getters. Updates serialization code and tests.
Description
Allows an SSE event to be created using no data. Uses a static constant SseEvent.NO_DATA to avoid returning null in getters. Updates serialization code and tests. See issue #9165.