4.x: fix getOrdinal for system property and environment variable config sources
#8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
May 11, 2024
barchetta
added a commit
to barchetta/helidon
that referenced
this pull request
May 13, 2024
barchetta
added a commit
to barchetta/helidon
that referenced
this pull request
May 13, 2024
barchetta
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConfigSource.getOrdinal()was returning 100 for the system property and environment variable config sources when the special propertyconfig_ordinalwas not set in the config source (instead of the correct value of 400 and 300).This PR corrects that and adds tests.
See MP Config Spec: https://download.eclipse.org/microprofile/microprofile-config-3.0/microprofile-config-spec-3.0.html#default_configsources
Fixes #8737
Documentation
No impact