Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve stability in details JSON output #8697

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Apr 23, 2024

Description

Resolves #8645

Use a TreeMap internally to preserve stability (and ordering) of details in JSON output.

Also, as is done elsewhere in health, pass a new map to the constructor in case the builder is mutated and reused.

Documentation

Bug fix; no doc impact.

@tjquinno tjquinno requested a review from tomas-langer April 23, 2024 11:33
@tjquinno tjquinno self-assigned this Apr 23, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 23, 2024
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test to make sure this does not happen again...

@tjquinno tjquinno merged commit 5afc6a0 into helidon-io:main Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health check response no longer orders the data details
2 participants