4.x: Update streaming example so it starts and downloads last uploaded file #8515

barchetta · 2024-03-22T00:17:22Z

This updates the webserver streaming example to:

Correct the README which still referred to reactive webserver APIs
Fix it so it can start by NOT using a zip file URI to access the download file (see examples/webserver/streaming fails to start #8477)
Have the upload set the file to download as described by the README

README has been updated

examples/webserver/streaming/src/main/java/io/helidon/examples/webserver/streaming/Main.java

...server/streaming/src/main/java/io/helidon/examples/webserver/streaming/StreamingService.java

romain-grecourt

Nice!

barchetta added 2 commits March 21, 2024 17:09

Update streaming example so it starts and downloads last uploaded file

47dc6b9

Fix copyright and cleanup includes

b2b7199

barchetta added examples 4.x Version 4.x labels Mar 22, 2024

barchetta requested a review from romain-grecourt March 22, 2024 00:17

barchetta self-assigned this Mar 22, 2024

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 22, 2024

Fix copyright

d7c53c8

romain-grecourt reviewed Mar 22, 2024

View reviewed changes

barchetta added 2 commits March 22, 2024 12:31

Update README with new location of large-file.bin

50be502

Simplify example to require upload first. Add tests.

e93b54a

barchetta requested a review from romain-grecourt March 22, 2024 19:35

romain-grecourt previously approved these changes Mar 22, 2024

View reviewed changes

Fix checkstyle

466edff

barchetta dismissed romain-grecourt’s stale review via 466edff March 22, 2024 20:25

barchetta requested a review from romain-grecourt March 22, 2024 21:08

romain-grecourt approved these changes Mar 22, 2024

View reviewed changes

barchetta merged commit f268194 into helidon-io:main Mar 22, 2024
12 checks passed

barchetta deleted the 4.x-streaming-example branch November 12, 2024 20:10

Provide feedback