Use OTel AgentDetector instead of just system property - review comments from earlier PR #8374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
approved these changes
Feb 13, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…nts from earlier PR (helidon-io#8374) * Review comments from earlier PR * One more place to use the AgentDetector * remove duplicate constant declarations
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…nts from earlier PR (helidon-io#8374) * Review comments from earlier PR * One more place to use the AgentDetector * remove duplicate constant declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8341
Update to #8360
Replaces simple check of system property with use of
AgentDetector.Documentation
No doc impact.