[3.x] Guard against NPE during early invocation of Span.current() #8256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Quinn <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
changed the title
tomas-langer
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8255
See description of scenario in the issue.
This PR changes
TracerProviderHelper#currentSpanto check ifTRACER_PROVIDERis null and, if so, returnsOptional.empty()for the current span instead of throwing the NPE.This should not happen unless a custom tracer provider tries, directly or indirectly, to use
Span.current()during its initialization.Documentation
Bug fix; no doc impact.