3.x Backport of scope/baggage fix #8244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Quinn <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
previously approved these changes
Jan 16, 2024
| @@ -27,6 +27,10 @@ | |||
| <artifactId>helidon-tracing-opentelemetry</artifactId> | |||
| <name>Helidon Tracing Open Telemetry</name> | |||
|
|
|||
| <properties> | |||
| <version.lib.opentelemetry-sdk-extension-autoconfigure>1.22.0-alpha</version.lib.opentelemetry-sdk-extension-autoconfigure> | |||
There was a problem hiding this comment.
(I assume we're OK with this property at this level, and not in dependencies/pom.xml as would normally be the case.)
There was a problem hiding this comment.
My understanding is that for "tangential" dependencies we don't want to load up dependencies/pom.xml with them.
Now, maybe OTel is becoming central enough that we do want them there but ideally there should be direct dependencies on OTel only from one (maybe two?) artifacts.
Maybe that's just for integrations and this usage is less tangential than those.
@tomas-langer @romain-grecourt Thoughts, folks?
...pentelemetry/src/main/java/io/helidon/tracing/opentelemetry/MutableOpenTelemetryBaggage.java
Outdated
Show resolved
Hide resolved
…lude baggage in span's context
ljnelson
approved these changes
Jan 18, 2024
| } | ||
|
|
||
| void baggage(String key, String value) { | ||
| values.put(key, new HBaggageEntry(value, new HBaggageEntryMetadata(""))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8211
Backport of PR #8225 - see the description there for full information.
Documentation
Bug fix - no doc impact.