-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check result of Integer.parseUnsignedInt() to be non-negative #8215
Conversation
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1CallChainBase.java
Outdated
Show resolved
Hide resolved
7e9caea
to
ba8182b
Compare
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
ba8182b
to
7a89f84
Compare
common/common/src/main/java/io/helidon/common/IntegerParser.java
Outdated
Show resolved
Hide resolved
common/common/src/main/java/io/helidon/common/ParserHelper.java
Outdated
Show resolved
Hide resolved
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1CallChainBase.java
Outdated
Show resolved
Hide resolved
webserver/webserver/src/main/java/io/helidon/webserver/http1/Http1Connection.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I don't like the name ParserHelper
(does it help parsers?) and I don't like the various invalid size supplier names (do they supply invalid sizes?) but these are minor concerns
4761676
to
62f2b76
Compare
Signed-off-by: Santiago Pericasgeertsen <[email protected]>
62f2b76
to
2be644b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough!
Description
Check result of Integer.parseUnsignedInt() to be non-negative. Issue #8218.
Documentation
None