New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New config builders #7008

Merged

tomas-langer merged 35 commits into helidon-io:main from tomas-langer:new-config-builders

Jun 23, 2023

Member

tomas-langer commented Jun 15, 2023 •

edited

Loading

Update to Helidon to provide support for (simplified) builders
Update to config driven to simplify it
Changes to pico and all related components to use (more) TypeName and new builder approach.

Force pushed with better commit structure.

Discovered my first build missed a few integration tests, fixing now.
20230616 - Pushed fixes of integration tests

List of follow ups: #7023
A problem discussed on this PR that requires more design: #7052

Also resolves:
#6566
#6719 - first step
#6908
#6947

oracle-contributor-agreement bot added the OCA Verified label

tomas-langer force-pushed the new-config-builders branch from 9a2cae5 to fe17333 Compare

June 15, 2023 16:18

tomas-langer requested review from trentjeff, romain-grecourt, danielkec and Verdent

June 15, 2023 16:18

tomas-langer self-assigned this

trentjeff reviewed

View reviewed changes

builder/README.md Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/README.md Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/README.md Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/README.md Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/README.md Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/pom.xml Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Outdated Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Outdated Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Outdated Show resolved Hide resolved

builder/api/src/main/java/io/helidon/builder/api/Prototype.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/ProvidedUtil.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/ProvidedUtil.java Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/ProvidedUtil.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/ProvidedUtil.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/io/helidon/builder/api/RuntimeType.java Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/api/src/main/java/module-info.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

...der/builder-config-processor/src/main/java/io/helidon/builder/config/processor/Versions.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java Outdated Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/CustomMethods.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/CustomMethods.java Show resolved Hide resolved

builder/processor/src/main/java/io/helidon/builder/processor/CustomMethods.java Show resolved Hide resolved

builder/processor/src/main/java/io/helidon/builder/processor/FactoryMethods.java Outdated Show resolved Hide resolved

builder/processor/src/main/java/io/helidon/builder/processor/FactoryMethods.java Outdated Show resolved Hide resolved

builder/processor/src/main/java/io/helidon/builder/processor/FactoryMethods.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java Show resolved Hide resolved

trentjeff reviewed

View reviewed changes

builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java Show resolved Hide resolved

tomas-langer added 16 commits

June 22, 2023 11:15


          Removed commented out code

672ec3c


          Review fix - unused variable.

53be2f1


          Review fix: fix javadoc

a38ac3e


          Fix module info


          Javadoc should be used even for processors

daa2a28


          TypeNames in common/types to add commonly used types as constants.

6b67236


          Fixed naming of builder interceptors and made them inner classes of b…

d26e953

…lueprints.

Also added a few missing `@Contract`


          Use self() instead of me()

6f24300

Use inner types for all things related to `Prototype` and `RuntimeType`
toString method now separates types with a semicolon
Use `clear` instead of `unset` for clearing optional values


          Review fixes.

d726029


          Rebased on main and fixed all compilation and test issues (hopefully)

ff99c8b


          Checkstyle fixes.

3f53d15


          Fix examples and obsolete dependencies

521f405


          Fix examples build method and wrong rebase for quickstarts

116cb17


          checkstyle fix

5596d0d


          Archetype fix

075947d


          rebased to resolve problems with neo4j example

tomas-langer force-pushed the new-config-builders branch from 6ddfd9e to 8381681 Compare

June 22, 2023 09:18


          Checkstyle fix.

fb69274

tomas-langer requested a review from trentjeff

June 22, 2023 11:04

tomas-langer mentioned this pull request

improve pico integration docs for oci sdk #7040

Merged

trentjeff reviewed

View reviewed changes

builder/README.md Show resolved Hide resolved

tomas-langer requested a review from trentjeff

June 22, 2023 15:42

trentjeff approved these changes

View reviewed changes

tomas-langer merged commit 5ccca37 into helidon-io:main

tomas-langer deleted the new-config-builders branch

June 23, 2023 09:03

This was referenced Jun 23, 2023

Níma: remove default config in webserver #6419

Closed

FT Nima does not support using Config to create handlers #6566

Closed

Generated builder code should use List.copyOf(l) instead of Collections.unmodifiableList(new ArrayList<>(l)) #6947

Closed

ConfiguredOption needs a "Security Sensitive" attribute and it needs to be incorporated into Builder #6908

Closed

tomas-langer mentioned this pull request

Nima should have http connection configurable per socket #5967

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels