Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x upgrade Weld #6775

Closed
wants to merge 2 commits into from
Closed

3.x upgrade Weld #6775

wants to merge 2 commits into from

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented May 5, 2023

Relates to #6576

@jbescos
4.x: Upgrade Weld to 5.x helidon-io#5815 (helidon-io#5830)
113c1fb 
4.x: Upgrade Weld to 5.x helidon-io#5815

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 5, 2023
@jbescos jbescos force-pushed the issue6576 branch 3 times, most recently from ff5f7d6 to b96ee20 Compare May 5, 2023 09:53
@jbescos
Additional fixes for Weld 5.x
682df74 
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@jbescos
Copy link
Member Author

jbescos commented May 5, 2023 •
edited
Loading

Build is failing with one error in the javadoc related to one external library. I think we should not validate javadocs of other libs, because we cannot fix them:

 /home/runner/.m2/repository/jakarta/interceptor/jakarta.interceptor-api/2.1.0/jakarta.interceptor-api-2.1.0.jar(/jakarta/interceptor/package.html):28: error: heading used out of sequence: <H3>, compared to implicit preceding heading: <H1>
<h3>Interceptor methods</h3>
^
1 error

barchetta
barchetta reviewed May 5, 2023
View reviewed changes
dependencies/pom.xml
<version.lib.jakarta.annotation-api>2.0.0</version.lib.jakarta.annotation-api>
<version.lib.jakarta.cdi-api>3.0.0</version.lib.jakarta.cdi-api>
<version.lib.jakarta.annotation-api>2.1.0</version.lib.jakarta.annotation-api>
<version.lib.jakarta.cdi-api>4.0.1</version.lib.jakarta.cdi-api>
Copy link
Member

@barchetta barchetta May 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. Helidon 3 is Jakarta EE 9, you are bumping specs to EE 10. As far as I know we should be sticking with Weld 4 / CDI 3 in Helidon 3. This comment applies to all the dependency upgrades you are making.

barchetta
barchetta requested changes May 5, 2023
View reviewed changes
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR goes too far as it appears to be upgrading to EE 10. Helidon 3 is EE 9.

@jbescos
Copy link
Member Author

jbescos commented May 10, 2023

I am closing this. I will create a new PR for Weld 4.0.3

@jbescos jbescos closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta requested changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbescos @barchetta