-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] - Additional @Retry strategies #5165
[3.x] - Additional @Retry strategies #5165
Conversation
|
||
|
||
@Override | ||
public Optional<Long> nextDelayMillis(long firstCallMillis, long lastDelay, int call) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be nice to add some tests that create a strategy and repeatedly call nextDelayMillis
to verify the sequence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added tests.
...-tolerance/src/main/java/io/helidon/microprofile/faulttolerance/RetryExponentialBackoff.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added
Exponential
andFibonacci
Retry strategies.Resolves #4413