Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] - Additional @Retry strategies #5165

Merged
merged 12 commits into from
Oct 22, 2022

Conversation

dalexandrov
Copy link
Contributor

Added Exponential and Fibonacci Retry strategies.

Resolves #4413

@dalexandrov dalexandrov added enhancement New feature or request 3.x Issues for 3.x version branch labels Oct 12, 2022
@dalexandrov dalexandrov self-assigned this Oct 12, 2022
@dalexandrov dalexandrov marked this pull request as ready for review October 13, 2022 10:37
@dalexandrov dalexandrov requested a review from spericas October 13, 2022 10:37


@Override
public Optional<Long> nextDelayMillis(long firstCallMillis, long lastDelay, int call) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be nice to add some tests that create a strategy and repeatedly call nextDelayMillis to verify the sequence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added tests.

Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a few minor comments.

@barchetta barchetta changed the title [3.x] Additional @Retry strategies [3.x] - Additional @Retry strategies Oct 19, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 19, 2022
@dalexandrov dalexandrov requested a review from spericas October 20, 2022 16:35
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalexandrov dalexandrov merged commit 893239c into helidon-io:helidon-3.x Oct 22, 2022
@dalexandrov dalexandrov deleted the 4413_Retry_strategies branch October 22, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement Request : Add support for exponential backoff retry in Helidon MP
2 participants